Skip to content

Add E2E tests setup for Auto Sizes #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: feature/1511-incorporate-layout-constraints-from-ancestors
Choose a base branch
from

Conversation

mukeshpanchal27
Copy link
Member

Summary

Part of #1511

Relevant technical choices

These PR add basic infrastructure for E2E test for Auto Sizes plugin.

Run npm run test-e2e for E2E tests in local.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature no milestone PRs that do not have a defined milestone for release [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) skip changelog PRs that should not be mentioned in changelogs labels Apr 16, 2025
@mukeshpanchal27 mukeshpanchal27 self-assigned this Apr 16, 2025
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.48%. Comparing base (2f01c04) to head (b4758e6).
Report is 301 commits behind head on feature/1511-incorporate-layout-constraints-from-ancestors.

Additional details and impacted files
@@                                      Coverage Diff                                       @@
##           feature/1511-incorporate-layout-constraints-from-ancestors    #1988      +/-   ##
==============================================================================================
+ Coverage                                                       69.60%   72.48%   +2.87%     
==============================================================================================
  Files                                                              86       85       -1     
  Lines                                                            7018     7051      +33     
==============================================================================================
+ Hits                                                             4885     5111     +226     
+ Misses                                                           2133     1940     -193     
Flag Coverage Δ
multisite 72.48% <ø> (+2.87%) ⬆️
single 40.43% <ø> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mukeshpanchal27
Copy link
Member Author

In b4758e6, I tried adding E2E tests to verify the image src before and after the plugin deactivation/activation.

When I run npm run test-e2e, it shows the same image URL (no change), but when I run npm run test-e2e:debug, it shows the expected smaller version image URL in debug mode.

Does anyone know why this might be happening or what could be causing the difference in behavior between normal and debug modes? cc. @joemcgill @felixarntz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant