Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administration: Allow filtering of bulk action fields #8536

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

aaronjorbin
Copy link
Member

This updates the patch from @ethitter to include inline documentation and a single filter

https://core.trac.wordpress.org/ticket/63005

This updates the patch from @ethitter to include inline documentation and a single filter

https://core.trac.wordpress.org/ticket/63005
Copy link

github-actions bot commented Mar 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorbin, davidbaumwald.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joedolson joedolson self-requested a review March 19, 2025 18:37
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a private variable used internally, I think that bulkFieldRelations is fine, but as an externally available filter, I think it's confusing; it doesn't really say anything about what this is used for.

What would you think about changing to something like bulkActionObserverIds ? This is really the array of field IDs that will be used to verify that a bulk action is taking place; the naming and documentation could make this a lot clearer.

@@ -1321,8 +1321,8 @@ $( function() {

// Observe submissions from posts lists for 'bulk_action' or users lists for 'new_role'.
var bulkFieldRelations = {
'bulk_action' : 'action',
'changeit' : 'new_role'
'bulk_action' : window.bulkFieldRelations.bulk_action,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use optional chaining here for cleaner and safer code?

'bulk_action' : 'action',
'changeit' : 'new_role'
'bulk_action' : window.bulkFieldRelations.bulk_action,
'changeit' : window.bulkFieldRelations.changeit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use optional chaining here for cleaner and safer code?

@joedolson joedolson changed the title Administration: Allow filtering of builk action fields Administration: Allow filtering of bulk action fields Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants