-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Administration: Allow filtering of bulk action fields #8536
base: trunk
Are you sure you want to change the base?
Conversation
This updates the patch from @ethitter to include inline documentation and a single filter https://core.trac.wordpress.org/ticket/63005
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: David B <[email protected]>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a private variable used internally, I think that bulkFieldRelations
is fine, but as an externally available filter, I think it's confusing; it doesn't really say anything about what this is used for.
What would you think about changing to something like bulkActionObserverIds
? This is really the array of field IDs that will be used to verify that a bulk action is taking place; the naming and documentation could make this a lot clearer.
@@ -1321,8 +1321,8 @@ $( function() { | |||
|
|||
// Observe submissions from posts lists for 'bulk_action' or users lists for 'new_role'. | |||
var bulkFieldRelations = { | |||
'bulk_action' : 'action', | |||
'changeit' : 'new_role' | |||
'bulk_action' : window.bulkFieldRelations.bulk_action, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use optional chaining here for cleaner and safer code?
'bulk_action' : 'action', | ||
'changeit' : 'new_role' | ||
'bulk_action' : window.bulkFieldRelations.bulk_action, | ||
'changeit' : window.bulkFieldRelations.changeit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use optional chaining here for cleaner and safer code?
This updates the patch from @ethitter to include inline documentation and a single filter
https://core.trac.wordpress.org/ticket/63005