Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick/bulk edit status icons, matching block editor #8547

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

adamsilverstein
Copy link
Member

Description

This PR adds status icons to the bulk edit and quick edit select elements. The svgs in the code are from the block editor which already shows a status icon next to each status, for example:

image

This PR adds those status icons to the status selector on the quick edit screen and bilk edit screen which currently look like this:

Quick edit:

image

Select detail:

image

Bulk edit:

image

Select detail:

image

After PR

After this PR, the select elements opt into the new Customizable Select API which enables HTML select elements. It then adds the svg icons from the editor to the selects. After the PR they look like this:

Quick edit:

status on quick edit

Bulk edit:

status on bulk edit

Trac ticket: No ticket yet, this is purely experimental.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant