Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Revert new default rendering mode for Pages #8557

Closed

Conversation

Mamaduka
Copy link
Member

Important

I want to highlight that limiting the ability to edit template parts in template-locked rendering mode is an intentional choice and isn't a bug.

Unfortunately, this can make the new default rendering mode confusing in some instances and prevent users from editing a post/page title.

PR reverts the new default rendering mode for Pages (WP-61811).

I'm not restoring the special case for the Site Editor, where the rendering mode was different from that of the Post Editor. Why?

  • Consistency - The new default's goal was to make the page editing experience consistent between the post and site editors. There should be only one default rendering mode per post type across the editors.
  • User preferences - The new persistent user preference allows users to set rendering mode based on their needs.
  • More logic, more problems - I don't want to complicate the logic for deriving the default rendering mode.

Trac ticket: https://core.trac.wordpress.org/ticket/63139

@Mamaduka Mamaduka self-assigned this Mar 21, 2025
Copy link

github-actions bot commented Mar 21, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mamaduka, joemcgill.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka requested review from joemcgill and audrasjb March 21, 2025 09:48
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I think folks will like this feature, opting in by default does create enough friction in real use cases that it probably does make sense to remove.

All the infrastructure is still in place for people to opt in to this default by modifying post type support for any post types that where they want this to be the default experience and when users change their template view while editing a post, that preference will be used the next time that user edits a post of the same post type, so this has been a worthwhile experiment, leading to some real improvements in the UX.

Thanks @Mamaduka!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 25, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 25, 2025
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60076
GitHub commit: 2bf5a23

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 25, 2025
@Mamaduka Mamaduka deleted the revert/new-default-mode-for-pages branch March 25, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants