Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up _doing_it_wrong() within wp_unique_id_from_values(). #8570

Closed
wants to merge 3 commits into from
Closed

Tidy up _doing_it_wrong() within wp_unique_id_from_values(). #8570

wants to merge 3 commits into from
+2 −4

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Mar 23, 2025 •
edited
Loading

A little tidy up of the DIW call within wp_unique_id_from_values():

  • Remove the unused sprintf
  • Figure whether the DIW should be used.

Trac ticket: https://core.trac.wordpress.org/ticket/62985, refer comment 8.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 23, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, joemcgill.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@peterwilsoncc peterwilsoncc requested a review from joemcgill March 23, 2025 22:13
@github-actions GitHub Actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

joemcgill
joemcgill previously approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @peterwilsoncc. This change looks good.

@joemcgill joemcgill dismissed their stale review March 24, 2025 19:01

Added new feedback

joemcgill
joemcgill approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works. Thanks @peterwilsoncc

@github-actions GitHub Actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60075
GitHub commit: a8b0726

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 25, 2025
@peterwilsoncc peterwilsoncc deleted the fix/62985-doing-it-wrong branch March 25, 2025 01:55
mukeshpanchal27
mukeshpanchal27 reviewed Mar 25, 2025
View reviewed changes
src/wp-includes/functions.php
__( 'The $data argument must not be empty.' ),
gettype( $data )
),
// translators: $data` is the parameter name and must not be translated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "`" is added after $data variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

@joemcgill joemcgill joemcgill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterwilsoncc @joemcgill @mukeshpanchal27