Stop crash with PHP extension update #2165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This work is continued from a PR started under the WordPress GH org. There are a couple of reasons for this upgrade: 1. I am having trouble rebuilding php-wasm on my current system. References to older ubuntu images and emscripten versions [has given me trouble](#2038 (comment)). 2. We want [this Emscripten fix](emscripten-core/emscripten#22932) from @jeroenpf and @bgrgicak which was first included in Emscripten 3.1.73. This PR: - Bumps the ubuntu docker image version due to build errors related to missing image. Referencing a newer ubuntu image seemed to fix the "missing image" errors. - Bumps Emscripten version - Adjusts Playground-specific patches to Emscripten output since the latest breaks that patching. - CI (once we can run GH actions on A8C's GHE instance) --------- Co-authored-by: Brandon Payton <[email protected]>
The original implementation of the DNS polyfill didn't register `DNS_*` constants which are [expected to exist in PHP](https://www.php.net/manual/en/network.constants.php#constant.dns-any). To fix this this PR registered the required DNS constants. The constants were already defined in the polyfill and now we register them as PH constants using `REGISTER_LONG_CONSTANT`. I didn't want to add more code to the `php_wasm.c` file that wasn't directly related to PHP-wasm, so I moved the DNS polyfill code to an extension. - CI
brandonpayton
added
[Type] Bug
|
Let's wait for CI tests to pass. And before merging, I would like to temporarily allow merging discrete commits from PRs in order to keep the two commits separate on trunk. The change should only remain for a moment so we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
This PR includes a couple of commits that have appeared to resolve PHP-related crashes in a private Playground instance.
cc @bph
Implementation details
There are two commits:
Testing Instructions (or ideally a Blueprint)