Stabilize legacy WordPress boot CI#3609
Open
JanJakes wants to merge 6 commits into
Open
Conversation
Cache legacy WordPress release ZIPs through Actions cache, serve them locally with CORS during the boot suite, and retry Playwright browser installation to absorb rare apt mirror failures.
Keep the activation wait at 60 seconds, then re-check the plugins page before failing and include the latest frame URL, body excerpt, and recent browser errors in timeout diagnostics.
Do not fail the legacy boot job if another workflow run saves the same WordPress ZIP cache key first.
akirk
force-pushed
the
fix/legacy-wp-ci-stability
branch
from
60c688e to
69a94c5
Compare
Use the existing CORS proxy hook for cached WordPress ZIPs so the test still passes dotted WordPress versions through the normal Playground resolver. This avoids the custom-URL branch that made older versions crawl to the CI timeout.\n\nAlso trims the plugin activation recovery to a URL-bar retry instead of direct scoped-frame URL rewriting.
Move the legacy WordPress boot helper scripts under one test-specific directory, use shorter names inside that directory, and update the workflow/project references.\n\nAlso narrow the local ZIP server back to cached WordPress ZIPs only and make WP_ONLY apply to the downloader so local focused runs do not need the full ZIP cache.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Stabilizes the legacy WordPress boot CI job by reducing external flake sources (WordPress.org throttling, Playwright install hiccups) and improving plugin activation diagnostics/timeouts.
Changes:
- Add download + local serving of cached WordPress ZIPs for the legacy boot test.
- Refactor legacy WP version matrix into a shared helper module.
- Improve CI robustness with Playwright install retries and better plugin-activation timeout reporting.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/wordpress/tests/legacy-wp-version-boot/test.mjs | Uses shared matrix helper and improves plugin activation waiting/diagnostics |
| packages/playground/wordpress/tests/legacy-wp-version-boot/matrix.mjs | Introduces shared WP/PHP matrix + download URL normalization helpers |
| packages/playground/wordpress/tests/legacy-wp-version-boot/download-zips.mjs | Adds CLI to pre-download ZIPs with retries for CI caching |
| packages/playground/wordpress/tests/legacy-wp-version-boot/serve-zips.mjs | Adds local HTTP server for serving cached ZIPs in CI |
| packages/playground/wordpress/src/legacy-wp/legacy-fixes.ts | Updates doc reference to the moved legacy boot test path |
| packages/playground/wordpress/project.json | Updates Nx command to new legacy boot test path |
| .github/workflows/ci.yml | Adds ZIP cache restore/save + local ZIP server + Playwright install retries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+71
to
+81
| function getProxiedUrl(requestUrl) { | ||
| const pathTarget = decodeURIComponent(requestUrl.pathname.slice(1)); | ||
| if (isHttpUrl(pathTarget)) { | ||
| return new URL(`${pathTarget}${requestUrl.search}`); | ||
| } | ||
| const searchTarget = requestUrl.search.slice(1); | ||
| if (isHttpUrl(searchTarget)) { | ||
| return new URL(searchTarget); | ||
| } | ||
| return null; | ||
| } |
Comment on lines
+68
to
+69
| createReadStream(filePath).pipe(response); | ||
| }); |
Comment on lines
+246
to
+269
| function getPluginActivationTimeoutStatus( | ||
| frameBeforeActivation, | ||
| latestFrame, | ||
| consoleErrors, | ||
| consoleStartIndex | ||
| ) { | ||
| const recentErrors = consoleErrors.slice(consoleStartIndex).slice(-3); | ||
| const detail = [ | ||
| `timed out after ${PLUGIN_ACTIVATION_TIMEOUT_S}s`, | ||
| `before URL: ${frameBeforeActivation.url}`, | ||
| latestFrame ? `latest URL: ${latestFrame.frame.url()}` : null, | ||
| recentErrors.length | ||
| ? `recent console errors: ${recentErrors.join(' | ')}` | ||
| : null, | ||
| ] | ||
| .filter(Boolean) | ||
| .join('; '); | ||
|
|
||
| return { | ||
| status: 'TIMEOUT', | ||
| detail, | ||
| body: latestFrame?.body, | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
wp=4.9style query values so Playground still uses the normal dotted-version resolver.packages/playground/wordpress/tests/legacy-wp-version-boot/.Why
The legacy boot job was frequently failing on transient infrastructure issues: WordPress.org download throttling, occasional Playwright install/network failures, and rare plugin activation timing races. The cache removes most WordPress.org traffic without changing the runtime code path under test.
Validation
WP_ONLY=6.2,4.9 node packages/playground/wordpress/tests/legacy-wp-version-boot/test.mjsnode --check, Prettier, filtered ZIP download, and ZIP server smoke tests.test-legacy-wp-version-bootpassed on the latest full run and prior targeted reruns.