Fix personal WP Health Check recovery boot#3637
Open
akirk wants to merge 1 commit into
Open
Conversation
972d143 to
71bccc9
Compare
71bccc9 to
c7cf897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
?playground-recovery-mode=health-checkquery param. → This also will allow us in support cases to just send the URL https://my.wordpress.net/?playground-recovery-mode=health-check to a userwp-load.phppath that can crash on broken active plugins.Why
The previous recovery flow inferred recovery mode from the decoded blueprint landing page. Personal WP could still run the WordPress install check before recovery setup, and that check loads
wp-load.php. If an active plugin fatals there, Health Check never gets installed.Testing
NX_ISOLATE_PLUGINS=false NX_DAEMON=false npm_config_cache=/tmp/npm-cache npm_config_update_notifier=false npm exec --offline -- nx test playground-personal-wpNX_ISOLATE_PLUGINS=false NX_DAEMON=false npm_config_cache=/tmp/npm-cache npm_config_update_notifier=false npm exec --offline -- nx run playground-personal-wp:typecheckNX_ISOLATE_PLUGINS=false NX_DAEMON=false npm_config_cache=/tmp/npm-cache npm_config_update_notifier=false npm exec --offline -- nx run playground-personal-wp:lint