fix: 2 improvements across 2 files - #4175
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Quality: Missing error handling for spawnSync in built-script executor - Quality: Typo in configuration value Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Quality: Missing error handling for spawnSync in built-script executor - Quality: Typo in configuration value Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Improves error visibility in the built-script Nx executor and fixes a typo in meta configuration.
Changes:
- Throw the underlying
spawnSyncerror when Node fails to spawn in thebuilt-scriptexecutor. - Correct typo in
teamname in meta config.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/nx-extensions/src/executors/built-script/executor.ts | Adds handling for spawnSync spawn failures via result.error. |
| packages/meta/src/config.ts | Fixes team string typo (“Playgrouns” → “Playground”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+21
| if (result.error) { | ||
| throw result.error; | ||
| } |
| slug: 'wordpress-playground', | ||
| name: 'Playground', | ||
| team: 'Playgrouns Core', | ||
| team: 'Playground Core', |
github-actions
Bot
added
the
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: 2 improvements across 2 files
Problem
Severity:
Medium| File:packages/nx-extensions/src/executors/built-script/executor.ts:L16The
built-scriptexecutor usesspawnSyncto run a Node.js script but does not checkresult.error. If thenodeexecutable is not found or fails to spawn,result.statuswill benull(which is not0), but the actual error is ignored, making debugging difficult.Solution
Check
result.errorand throw or log an appropriate error if the spawn fails before checkingresult.status.Changes
packages/nx-extensions/src/executors/built-script/executor.ts(modified)packages/meta/src/config.ts(modified)