[Website] Reuse DropdownMenu for Site Settings actions - #4206
Open
adamziel wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors the Site Settings split-button action menu to use shared WordPress DropdownMenu/MenuGroup components (and MenuItemWithDescription) instead of bespoke buttons/keyboard handling, while aiming to preserve the existing visuals and behavior.
Changes:
- Replaced the custom
Dropdowntoggle + hand-rolled menu and keyboard navigation withDropdownMenu+MenuGroup+MenuItemWithDescription. - Updated menu styling selectors to target the new component markup (menu item structure, disabled state, focus styles).
- Kept the unavailable “Apply” action in keyboard navigation, exposing its explanation text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/playground/website/src/components/site-manager/site-settings-form/site-settings-action-footer.tsx | Swaps custom dropdown/menu implementation for shared menu primitives and updates disabled/selection behavior. |
| packages/playground/website/src/components/site-manager/site-settings-form/style.module.css | Adjusts CSS selectors to style the new DropdownMenu/MenuItemWithDescription DOM structure and focus/disabled states. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamziel
force-pushed
the
adamziel/reuse-site-settings-action-menu
branch
from
July 29, 2026 16:08
c63506b to
bc7c48d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Site Settings action menu's hand-rolled buttons with
DropdownMenu,MenuGroup, andMenuItemWithDescription.All website
DropdownMenuuses now go through one wrapper. It supplies Homeand End navigation and a visible inset focus ring. Ordinary choices use
Gutenberg's menu states: black text on a transparent background at rest, then
accent-blue text on the same transparent background on hover. Disabled choices
stay muted and destructive choices stay red.
Site Settings keeps its split-button shape, 20px horizontal menu padding,
descriptions, separators, and responsive placement. Opening a menu focuses its
first available action. An unavailable Apply to this Playground remains in
keyboard navigation so its explanation is reachable without enabling it.
Before and after
Blueprint Export
Desktop
Mobile
Saved Playground actions
Desktop
Mobile
Site Settings: Apply is available
Desktop
Mobile
Site Settings: a fresh Playground is required
Desktop
Mobile
Testing
Open the Blueprint Export, Saved Playground actions, and Site Settings menus on
desktop and mobile. Confirm ordinary choices share the same resting, hover, and
focus states. Confirm disabled choices remain muted, Delete remains red, and
the Site Settings menu keeps its spacing and wrapping. Use Arrow Up, Arrow
Down, Home, and End to move through each menu.