Lazy-load optional OPFS Blueprint dependencies - #4218
Closed
ashfame wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 30, 2026
ashfame
force-pushed
the
agent/opfs-export-boundary
branch
from
July 30, 2026 15:03
bee906f to
8cb9ca4
Compare
ashfame
marked this pull request as ready for review
July 30, 2026 15:04
ashfame
force-pushed
the
agent/opfs-export-boundary
branch
from
July 30, 2026 16:50
8cb9ca4 to
3912eb4
Compare
ashfame
force-pushed
the
agent/opfs-export-boundary
branch
from
July 30, 2026 19:31
3912eb4 to
fe66b7e
Compare
Member
Author
|
Optimization analysis reveals no savings, but negligibly worse: The lazy version is negligibly larger: 0.064% raw and 0.004% gzip. The reason is Rollup’s chunk assignment:
Hence, Closing this PR. cc: @brandonpayton |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keeps saved-site metadata serialization in
opfs-site-storage.tsand loads Blueprint bundle storage only when a Blueprint-backed site is read or reset. Export-only consumers avoid eagerly loading the optional Blueprint editor path without introducing a separate metadata serializer.Why
Bundle restoration and reset support are conditional, while metadata serialization belongs with the OPFS storage implementation. This keeps the useful lazy boundary and addresses the review concern about moving
metadataToStoredFormat()solely for loading behavior.Stack
Checks
npm exec nx test playground-websitenpm exec nx lint playground-websitenpm exec nx typecheck playground-websitenpm exec nx build playground-website