Fix doc screenshots skill Markdown - #4239
Conversation
github-actions
Bot
added
the
[Type] Documentation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Repairs the doc-screenshots skill’s Workflow Markdown so nested fenced code blocks and setup commands render and copy/paste correctly.
Changes:
- Re-formatted numbered workflow steps to avoid malformed nested Markdown around fenced code blocks.
- Consolidated previously wrapped paragraphs/commands to preserve spacing and inline-code integrity.
- Tweaked the Playwright snippet for clarity (factor viewport into a variable).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| **WordPress modals:** Editor screens open welcome guides ("Edit your site" → Get started) whose overlay swallows clicks; some have no `aria-label="Close"` button. Dismiss with an Escape loop — while `.components-modal__screen-overlay` exists, press Escape on the frame's body, wait ~1s — and retry the blocked click between attempts. The modal can appear _after_ the page looks loaded, so dismiss lazily around the click, not once up front. | ||
|
|
||
| Prefer driving the browser from Node with the repo's own `node_modules/playwright`; otherwise run `pip install playwright && playwright install chromium`, or use the Chrome DevTools MCP capture tools. |
There was a problem hiding this comment.
Updated in 37b1bf6: the fallback now invokes both pip and Playwright through python3 -m ..., so the browser installation is bound to the same Python environment.
| python .agents/skills/doc-screenshots/scripts/annotate.py config.json --crops crops/ | ||
| ``` | ||
|
|
||
| The script needs Python with Pillow. If no suitable interpreter is active, create a virtual environment in the session scratchpad with `python3 -m venv <scratchpad>/venv && <scratchpad>/venv/bin/pip install Pillow`, then call that interpreter directly. The script validates the config up front and exits with a readable `config error:` message on bad input; `output` must be a `.webp` path. |
There was a problem hiding this comment.
Updated in 37b1bf6: the virtual-environment setup now uses <scratchpad>/venv/bin/python -m pip install Pillow, explicitly binding pip to that interpreter.
|
@fellyph This got flagged while working on something so fixed it. After fixing, I tested it and it still works as expected. Screenshot attached in PR description. |
What
Repair malformed Markdown in the
doc-screenshotsskill's Workflow section so its instructions render correctly and commands remain copyable. Additionally, remove the line wrapping from other lines to be consistent in raw form.Problems fixed
`config error:`messageand`output` must be a`.webp`.What was not the issue
Ordinary prose wrapping was not the underlying bug, and skill files are not categorically forbidden from containing wrapped prose. The edited paragraphs are kept unwrapped to follow this repository's Markdown convention, but the functional problem was malformed Markdown structure and broken commands.
Impact
This changes only the skill instructions. The annotation script, examples, and runtime behavior are unchanged.
Checks
quick_validate.py .agents/skills/doc-screenshotsprettier --check .agents/skills/doc-screenshots/SKILL.mdgit diff --checkCreated screenshots