Fix PHP 8.4 deprecations and attend-event fatal error#384
Merged
Conversation
dd32
force-pushed
the
fix/claude/php84-compat-and-attend-error
branch
from
4713dca to
a2a56fe
Compare
wp_get_current_user() always returns a WP_User object (with ID=0 for guests), so the check `! $user` never triggered. This allowed user_id=0 to reach the Attendee constructor, which throws "invalid user id". Use get_current_user_id() and check for a falsy value instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PHP 8.4 deprecates implicit nullable types (e.g. Type $param = null). Updated all instances to use explicit nullable syntax (?Type $param = null) in event.php and event-date.php. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dd32
force-pushed
the
fix/claude/php84-compat-and-attend-error
branch
from
a2a56fe to
b6b4bd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix fatal error when non-logged-in users attend an event:
wp_get_current_user()always returns aWP_Userobject (withID=0for guests), so the! $userguard never triggered. This alloweduser_id=0to reach theAttendeeconstructor, throwing "invalid user id". Replaced withget_current_user_id()which properly returns0for guests and can be checked as falsy.Fix PHP 8.4 implicit nullable type deprecations: Updated 7 instances of
Type $param = nullto?Type $param = nullacrossevent.phpandevent-date.phpto silence PHP 8.4 deprecation warnings.Test plan
🤖 Generated with Claude Code