Skip to content

Update to PHP 8.4 and use wp-env for CI tests#385

Merged
dd32 merged 2 commits intotrunkfrom
fix/claude/php84-wp-env-ci
Mar 9, 2026
Merged

Update to PHP 8.4 and use wp-env for CI tests#385
dd32 merged 2 commits intotrunkfrom
fix/claude/php84-wp-env-ci

Conversation

@dd32
Copy link
Copy Markdown
Member

@dd32 dd32 commented Mar 9, 2026

Summary

  • Fix PHP 8.4 implicit nullable type deprecations across event.php and event-date.php
  • Replace custom install-wp-tests.sh CI setup with wp-env (resolves svn: command not found failures)
  • Test matrix updated from PHP 7.4/8.3 to PHP 8.4/8.5
  • Update wp-env default PHP version to 8.4
  • Widen PHPUnit constraint to ^9.6 || ^10.0 || ^11.0 and polyfills to ^2.0 || ^3.0
  • Remove PHPUnit 10-incompatible XML attributes (convertErrorsToExceptions, etc.)
  • Update coding standards workflow to PHP 8.4

Test plan

  • PHPUnit passes on PHP 8.4
  • PHPUnit passes on PHP 8.5
  • PHPCS passes on PHP 8.4
  • Local development with composer dev:test still works

🤖 Generated with Claude Code

dd32 and others added 2 commits March 9, 2026 15:06
- Replace custom install-wp-tests.sh CI setup with wp-env
- Test against PHP 8.4 and 8.5 (dropping 7.4)
- Update wp-env default PHP version to 8.4
- Update coding standards workflow to PHP 8.4
- Widen composer PHPUnit constraint to support 9.6/10/11
- Widen yoast/phpunit-polyfills to ^2.0 || ^3.0
- Remove PHPUnit 10-incompatible XML attributes

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update bootstrap.php to detect GlotPress directory name
  case-insensitively (wp-env installs as 'GlotPress' not 'glotpress')
- Use --force flag for npm install to avoid EEXIST cache errors

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dd32 dd32 force-pushed the fix/claude/php84-wp-env-ci branch from 1d41867 to a620d9d Compare March 9, 2026 05:06
@dd32 dd32 merged commit 231f051 into trunk Mar 9, 2026
3 checks passed
@dd32 dd32 deleted the fix/claude/php84-wp-env-ci branch March 9, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant