Skip to content

Remove workaround for modal closing in Firefox #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamwoodnz wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Remove workaround for modal closing in Firefox #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions settings/src/components/revalidate-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
title="Two-Factor Authentication"
onRequestClose={ goBack }
className="wporg-2fa__revalidate-modal"
// Temporary workaround until https://github.com/WordPress/gutenberg/issues/40912 is fixed.
// Without this the modal immediately closes in Firefox, see https://github.com/WordPress/wporg-two-factor/issues/180
shouldCloseOnClickOutside={ false }
>
<p>To update your two-factor options, you must first revalidate your session.</p>

Expand Down Expand Up @@ -66,7 +63,7 @@
return () => {
window.removeEventListener( 'message', maybeRefreshUser );
};
}, [] );

Check warning on line 66 in settings/src/components/revalidate-modal.js

View workflow job for this annotation

GitHub Actions / All 

React Hook useEffect has missing dependencies: 'record' and 'userRecord'. Either include them or remove the dependency array

return (
<iframe
Expand Down
Loading