Conversation
…TypeUsage in source AST
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalVariableDeclaration,EnhancedFor,CatchClause, andLambdaParameterwere storing source-form type name strings (via.toString()on javac tree nodes) instead of resolvedTypeUsageobjects, preventing these nodes from participating in type-system analysis.The fix threads the existing type-resolution context (
Trees,CompilationUnitTree,typeResolver) intoJdkStatementConvertervia a newsetTypeContext()method — mirroring the pattern already used byJdkExpressionConverter. AresolveTypeUsage(Tree)helper is added to both converters that follows the sameTreePath → TypeMirror → TypeUsagepath already used for method return types, field types, and formal parameters.JdkInitializerwires the statement converter into context alongside the expression converter. Node schemas and marshalling are updated accordingly.var-inferred types and unresolvable types fall back toUnknownTypeUsage, consistent with how the expression converter handles errors.