Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unqualified method calls like
foo()previously had noreceiverTypein theMethodInvocationmodel node, while qualified calls likethis.foo()andobj.foo()did. The implicit receiver for an unqualified call is always the enclosing class instance.JdkExpressionConverternow tracks the enclosing class type viasetEnclosingType(), called fromJdkInitializer.visitClassbeforeprocessTypeElementruns. The unqualified branch ofvisitMethodInvocationuses this asreceiverTypeinstead of leaving it empty.Tests updated: the existing assertion that unqualified calls have empty
receiverTypeis replaced with two new tests — one verifying resolution to the enclosing class, one verifying inner class calls resolve to the inner class type (not the outer).