feat(jdk-codemodel): parse module-info.java and model JPMS directives#21
Merged
feat(jdk-codemodel): parse module-info.java and model JPMS directives#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JdkInitializernow visitsModuleTreecompilation units in addition toClassTree. All JPMS directives are captured as traits onModuleDescriptor:ExportsDescriptor—exports(qualified and unqualified)OpensDescriptor—opens(qualified and unqualified)ProvidesDescriptor—provides ... with ...(service type + implementations asTypeUsage)UsesDescriptor—uses(service type asTypeUsage)RequiresModifier—TRANSITIVE/STATICqualifiers onRequiresModuleDescriptorOpenModule— marker foropen moduleAll new traits are lightweight records in
jdk-codemodel.RequiresModifieris jdk-specific and lives there rather than incodemodel-foundation.