feat(jdk-codemodel): resolve method invocations to MethodDescriptor#23
Merged
feat(jdk-codemodel): resolve method invocations to MethodDescriptor#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ResolvedMethod, a@SingularTraitonMethodInvocationthat points to theMethodDescriptorthe call site refers to.JdkExpressionConverter.visitMethodInvocationnow callsresolveMethod, which walks javac'sTrees.getElementon the method-select subtree to get theExecutableElement, looks up the declaring type in theCodeModel, and matches by name, arity, and parameter type canonical names. If the declaring type is not in theCodeModel(JDK types, external libraries), no trait is attached. Three tests cover same-type calls, inherited methods resolving to the declaring supertype, and JDK calls producing no trait.