Conversation
… in reflection path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDKCodeModel already resolved TypeVariable correctly when encountered in field/method type signatures, but never attached a ParameterizedTypeDescriptor to the type descriptor itself — so class Foo and class Bar loaded via reflection appeared non-generic at the type level.
The fix replaces the TODO comment at line 410 of JDKCodeModel.java with a call to classType.getTypeParameters(), mapping each TypeVariable through the existing getTypeUsage() infrastructure (which already handles bounds, self-referential guards, etc.) and adding a ParameterizedTypeDescriptor trait when type parameters are present.
Two new tests in JDKCodeModelTests cover the unbounded (Container) and bounded (BoundedContainer) cases via the reflection path