Work around invalid override error when args 2.7.0 is pulled in (Dart 3.3+ only issue) #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
args
package just released 2.7.0, which adds an optional param inArgParser.flag
.This breaks dart_dev's override of this method, resulting in the following errors when attempting to analyze or run dart_dev code:
This can be seen in the "Dart stable" CI runs here: #449
Note that this version of
args
has an SDK constraint of>=3.3.0
, so this only affects Dart 3 consumers.Solution
Add an arg of the same name to fix the analysis error.
Unless we want to constrain ourselves to args
>= 2.7.0
(and as a result Dart>=3.3.0
), we're unable to forward this argument, but since this new argument isn't critical, ignoring it for now seemed like a worthwhile tradeoffTesting
CI passes in all Dart versions