Allow custom timestamps to be used on Span.end() #115
Merged
+41
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelring
requested review from
evanweible-wf,
dustinlessard-wf and
a team
as code owners
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
blakeroberts-wk
previously approved these changes
Aug 11, 2023
|
@rafaelring would you mind merging master or rebasing off master? |
rafaelzlisboa
force-pushed
the
span-endtime
branch
2 times, most recently
from
9e978bd to
db45aee
Compare
|
Hi folks, sorry for the radio silence! We've updated the branch with the current master and will update the code to be compatible with master :) |
rafaelzlisboa
force-pushed
the
span-endtime
branch
from
db45aee to
ce8154e
Compare
|
@blakeroberts-wk how could we get approval to run the CI again? I belive we've addressed the changes that made it break last time 😓 |
test/integration/sdk/span_test.dart
Outdated
| [], | ||
| sdk.SpanLimits(), | ||
| startTime); | ||
| expect(span.startTime, Int64(1000000000000)); |
There was a problem hiding this comment.
Suggested change
| expect(span.startTime, Int64(1000000000000)); | |
| expect(span.startTime, startTime); |
test/integration/sdk/span_test.dart
Outdated
| span.end(endTime: Int64(1000000020000)); | ||
| expect(span.startTime, Int64(1000000000000)); | ||
| expect(span.endTime, Int64(1000000020000)); | ||
| expect(span.endTime, greaterThan(span.startTime)); |
There was a problem hiding this comment.
nit: remove line, unnecessary expectation given the previous line
test/integration/sdk/span_test.dart
Outdated
| verifyNever(() => mockProcessor1.onEnd(span)); | ||
| verifyNever(() => mockProcessor2.onEnd(span)); | ||
|
|
||
| span.end(endTime: Int64(1000000020000)); |
There was a problem hiding this comment.
Suggested change
| span.end(endTime: Int64(1000000020000)); | |
| final endTime = Int64(1000000020000); | |
| span.end(endTime: endTime); |
test/integration/sdk/span_test.dart
Outdated
|
|
||
| span.end(endTime: Int64(1000000020000)); | ||
| expect(span.startTime, Int64(1000000000000)); | ||
| expect(span.endTime, Int64(1000000020000)); |
There was a problem hiding this comment.
Suggested change
| expect(span.endTime, Int64(1000000020000)); | |
| expect(span.endTime, endTime); |
As it's possible for Spans to be started with a custom startTime, this commit adds support for ending a span with a custom endTime.
rafaelzlisboa
force-pushed
the
span-endtime
branch
from
ce8154e to
50e82aa
Compare
|
@blakeroberts-wk thank you for the review - changes made :) |
blakeroberts-wk
approved these changes
May 10, 2024
|
@Workiva/release-management-p |
|
QA +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently it's possible to start spans with a custom
startTimebut it isn't possible to set a customendTimewhen ending them. This is useful for dispatching spans that happened on a different time window than the moment in whichstart()/end()were called.Short description of the change
This PR adds a new optional
endTimeparameter to theSpan.end()method which allows a customendTimeto be set on the Span rather than always using thetimestamp.now.How Has This Been Tested?
Added a new integration test in which we create a Span with a custom
startTimeand then end it with a customendTimeand validate the actual reported timestamps.Checklist: