Update GHA publishing steps #163
Conversation
michaelyeager-wf
requested review from
evanweible-wf,
dustinlessard-wf and
a team
as code owners
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Looks good to me based and worked for the other repo
Im not sure if there's a way to test this prior to tag - so lets see how it goes!
Check here for latest version getting pushed from the action
https://pub.dev/packages/opentelemetry
michaelyeager-wf
dismissed stale reviews from blakeroberts-wk and keruitan-wk
via
1f8d135
|
@Workiva/release-management-p |
|
Added steps tested working in another repo. We cannot test here without pushing, and cannot do so before merge. QA +1 |
| permissions: | ||
| id-token: write # Required for authentication using OIDC | ||
| uses: dart-lang/setup-dart/.github/workflows/publish.yml@v1 | ||
| name: Publish to pub.dev |
There was a problem hiding this comment.
Is there any reason here that we aren't using the supplied action? We just need to enable the package to run automated publishes and it should be good to go?
There was a problem hiding this comment.
There was a problem hiding this comment.
We just need to enable the package to run automated publishes and it should be good to go?
We've made the pub-side configuration updates as-described, but using the shared workflow from the linked documentation has resulted in the following in the past:
dart-lang/setup-dart/.github/workflows/publish.yml@v1 is not allowed to be used in Workiva/opentelemetry-dart.
Reusable workflows in this workflow must be:
within a repository that belongs to your Enterprise account or matching the following:
dart-lang/setup-dart@*, peter-evans/create-pull-request@*, denoland/setup-deno@*, romeovs/lcov-reporter-action@*, dorny/test-reporter@refs/tags/v1.6.0, dorny/test-reporter@e9fa2f582c0ebbe2e263fd18fad744d52e0b0203, maxim-lobanov/setup-xcode@9a697e2b393340c3cacd97468baa318e4c883d98, pypa/gh-action-pypi-publish@*, subosito/flutter-action@*, coursier/setup-action@*, browser-actions/setup-chrome@*, mikepenz/action-junit-report@150e2f992e4fad1379da2056d1d1c279f520e058, invertase/github-action-dart-analyzer@1cda5922c6369263b1c7e2fbe281f69704f4d63e, golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299, mikefarah/yq-portable-yaml-processor@845d4ae38915c31cc76ab968393657cceaec60fc, Workiva/gha-integration-testing@26fa4acd141cb143661af9e...
as here: https://github.com/Workiva/opentelemetry-dart/actions/runs/6828348643
|
Closing to open a fresh PR for compliance with audit tooling. |
Which problem is this PR solving?
This PR updates the GHA publish steps to allow publishing this package to be automated.
Checklist: