FED-3977 Allow analyzer 7 #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors look like:
Failed to load "test/vm_tests/builder/declaration_parsing_test.dart":
../../../.pub-cache/hosted/pub.dev/build_test-2.2.3/lib/src/in_memory_reader.dart:16:16: Error: Type 'MultiPackageAssetReader' not found.
implements MultiPackageAssetReader, RecordingAssetReader {
Since Dart 3 can still resolve to 2.x when using older analyzer versions
| - name: Delete Dart-2-only files when running on Dart 3 | ||
| - id: install | ||
| name: Install dependencies | ||
| run: dart pub get |
Contributor
Author
There was a problem hiding this comment.
Moved pub get one step earlier in all these, since update_tests_for_dart_3.sh reads the resolved version in pubspec.lock
| final nullSafetyCommentText = 'Using nullSafety: $nullSafety.${nullSafety ? ' ' : ''} $nullSafetyReason'; | ||
|
|
||
| // Generated part files must have matching language version comments, so copy them over if they exist. | ||
| // TODO use CompilationUnit.languageVersionToken instead of parsing this manually once we're sure we can get on analyzer version 0.39.5 or greater |
Contributor
Author
There was a problem hiding this comment.
Addressed this while I was in here
| @@ -0,0 +1,33 @@ | |||
| import 'dart:mirrors'; | |||
Contributor
Author
There was a problem hiding this comment.
FYI this isn't the first usage of dart:mirrors in over_react's builder; it's also used by instantiateAnnotation here in transformer_utils, which is used in most of the places the builder reads fields on annotations (e.g., @Props(...), @Accessor(...)).
sydneyjodon-wk
approved these changes
Jul 16, 2025
Contributor
sydneyjodon-wk
left a comment
sydneyjodon-wk
left a comment
There was a problem hiding this comment.
+10 🎉
- CI passes
- verified that all stable / Dart 3 CI runs are running on analyzer 7 as expected
Contributor
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
over_react supports analyzer
>=5.13.0 <7.0.0, which doesn't include the latest 7.x releases.We want to support the latest analyzer, to unblock upgrading packages that depend on newer analyzer versions.
Changes
package:analyzerin over_react were affectedlanguageVersionCommentneeded in dart+style 3.xset -x)Release Notes
>=5.13.0 <8.0.0(allow v8)>=2.0.0 <4.0.0(allow v3)Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: