-
Notifications
You must be signed in to change notification settings - Fork 6
S215 : build warnings #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S215 : build warnings #1077
Conversation
…ensitive property handling and clean up imports, avoiding build warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses build warnings by adding @Serial annotations to serializable classes and replacing deprecated Apache Commons and Jackson APIs with their modern equivalents. The changes modernize code to eliminate IDE and Maven build warnings without altering functionality.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| GcpApiDataRequestHandler.java | Replaces deprecated RandomUtils with ThreadLocalRandom |
| APIGatewayV2HTTPEventRequestAdapter.java | Replaces deprecated ObjectUtils.defaultIfNull with Objects.requireNonNullElse and reorganizes imports |
| APIGatewayV1ProxyEventRequestAdapter.java | Replaces deprecated ObjectUtils.defaultIfNull with Objects.requireNonNullElse and reorganizes imports |
| AwsModule.java | Refactors ObjectMapper creation to use JsonMapper builder pattern |
| FieldTransform.java | Removes incorrect @nonnull annotation from primitive boolean field and reorganizes imports |
| WebhookCollectionRules.java | Adds @serial annotation and reorganizes imports |
| RecordRules.java | Reorganizes imports |
| JsonSchemaFilterUtils.java | Adds @serial annotation to serialVersionUID |
| Endpoint.java | Reorganizes imports |
| ColumnarRules.java | Adds @serial annotation and reorganizes imports |
| RecordBulkDataSanitizerImpl.java | Replaces deprecated CSVFormat methods with builder pattern and reorganizes imports |
| ColumnarBulkDataSanitizerImpl.java | Replaces deprecated CSVFormat methods with builder pattern and reorganizes imports |
| StorageHandler.java | Replaces StringUtils.equals with Objects.equals for null-safe comparison and adds @serial annotation |
| ClientCredentialsGrantTokenRequestBuilder.java | Reorganizes imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
java/impl/gcp/src/main/java/co/worklytics/psoxy/GcpApiDataRequestHandler.java
Show resolved
Hide resolved
...l/aws/src/main/java/co/worklytics/psoxy/aws/request/APIGatewayV2HTTPEventRequestAdapter.java
Outdated
Show resolved
Hide resolved
.../aws/src/main/java/co/worklytics/psoxy/aws/request/APIGatewayV1ProxyEventRequestAdapter.java
Outdated
Show resolved
Hide resolved
java/core/src/main/java/co/worklytics/psoxy/storage/impl/RecordBulkDataSanitizerImpl.java
Show resolved
Hide resolved
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Fixes
@Serialto avoid ide warningsChange implications
hopefully nothing; ensure tests pass
Note
Focuses on warning cleanup and minor API modernizations across modules; no functional changes intended.
@SerialserialVersionUIDto multipleSerializabletypes (StorageHandler.ObjectTransform,ColumnarRules,JsonSchemaFilterUtils.Options,WebhookCollectionRulesand nested classes)Objects.equalsoverStringUtils.equalsfor gzip checks and useObjects.requireNonNullElsefor header merging in AWS request adaptersCSVFormat.DEFAULT.builder().get()and align header handling inColumnarBulkDataSanitizerImplandRecordBulkDataSanitizerImplRandomUtilswithThreadLocalRandomfor sampling in GCP handler; keep ~1% warning samplinglambdaEventMapperviaJsonMapper.builder()with case-insensitive propertiesWritten by Cursor Bugbot for commit ef41b2d. This will update automatically on new commits. Configure here.