fix click on space pill opening the page

WorldBrain · Jul 30, 2024 · 09caa76 · 09caa76
1 parent 668d7f7
commit 09caa76
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 17 deletions.
diff --git a/src/common-ui/components/result-item-spaces-segment.tsx b/src/common-ui/components/result-item-spaces-segment.tsx
@@ -92,9 +92,12 @@ export default function ListsSegment({
                         return (
                             <ListSpaceContainer
                                 key={space.id}
-                                onClick={(e) => {
-                                    e.stopPropagation()
-                                    onListClick(space.id)
+                                onMouseDown={(event: React.MouseEvent) => {
+                                    event.stopPropagation()
+                                    onListClick(space.id, event)
+                                }}
+                                onMouseUp={(event: React.MouseEvent) => {
+                                    event.stopPropagation()
                                 }}
                                 isLoading={space.name == null && space != null}
                                 title={

diff --git a/src/in-page-ui/ribbon/react/components/ribbon.tsx b/src/in-page-ui/ribbon/react/components/ribbon.tsx
@@ -1994,20 +1994,6 @@ export default class Ribbon extends Component<Props, State> {
                         }}
                     >
                         <Icon
-                            // onClick={(event) => {
-                            //     if (this.props.showRemoveMenu) {
-                            //         this.props.handleRemoveRibbon()
-                            //     } else {
-                            //         this.props.toggleRemoveMenu()
-                            //     }
-                            // }}
-                            // onClick={(event) => {
-                            //     if (event.shiftKey && this.props.isRibbonEnabled) {
-                            //         this.props.handleHover()
-                            //     } else {
-                            //         this.props.handleRemoveRibbon()
-                            //     }
-                            // }}
                             color={'greyScale5'}
                             heightAndWidth="24px"
                             padding="4px"