Fix editing of policy subjects and environments#199
Merged
pavelhoral merged 1 commit intoWrenSecurity:mainfrom Jun 13, 2025
Merged
Fix editing of policy subjects and environments#199pavelhoral merged 1 commit intoWrenSecurity:mainfrom
pavelhoral merged 1 commit intoWrenSecurity:mainfrom
Conversation
krausvo1
commented
Jun 11, 2025
Contributor
Author
There was a problem hiding this comment.
These changes fix usage of jQuery Deferred methods after upgrade from 2.x to 3.x.
krausvo1
force-pushed
the
policy_edit_fix
branch
from
84d5c06 to
5b115cd
Compare
krausvo1
force-pushed
the
policy_edit_fix
branch
from
5b115cd to
61f5057
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the previous wrensec-ui ugprades contains upgrade of jQuery (from 2.x to 3.x), which broke edit Policy page, specifically Subjects and Environments sections (see issue #200) I believe the issue are jQuery's Deferred behavior changes (see https://jquery.com/upgrade-guide/3.0/#deferred):
I believe this broke the mentioned sections where we assumed rendering of condition views was synchronous.
This PR fixes the mentioned sections. During my testing I have found some minor issues caused by invalid setting of subjects and environments. These issues were present before mentioned wrensec-ui upgrade, I didn't fix all of them in this PR.
Recording of the fixed sections:
https://github.com/user-attachments/assets/55d78cae-c52e-425e-bd95-fb463f2834f1