Make use of polling wait callback within Duo authentication module#204
Merged
pavelhoral merged 1 commit intoWrenSecurity:mainfrom Jul 18, 2025
Conversation
kovaceviccz
changed the title
pavelhoral
reviewed
Jul 16, 2025
pavelhoral
reviewed
Jul 16, 2025
pavelhoral
reviewed
Jul 16, 2025
kovaceviccz
force-pushed
the
make-use-of-polling-wait-callback-within-duo-authentication-module
branch
from
c36ecb8 to
3d456b0
Compare
Contributor
Author
|
Thanks for the review, @pavelhoral. Turns out I had a flawed understanding of the Duo authentication module. I've just pushed a new version of the PR that makes use of the polling wait callback in a more conservative manner, while still addressing the form re-render concern. Let me know what you think now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
PollingWaitCallbackto the Duo authentication module, allowing the UI to poll the authentication state without requiring additional logic. Additionally,RESTLoginView.jswas updated to correctly handle stale polling state. Previously, the form would not re-render when two or more consecutive authentication modules included aPollingWaitCallback, or when authentication was preceded by a failure in a stage that also usedPollingWaitCallback.