Migrate to Jakarta Servlet 5.0#205
Merged
pavelhoral merged 2 commits intoWrenSecurity:mainfrom Jul 30, 2025
Merged
Conversation
karelmaxa
force-pushed
the
migrate-jakarta-ee-servlet
branch
from
bc2ac6e to
db11d07
Compare
pavelhoral
approved these changes
Jul 30, 2025
Member
pavelhoral
left a comment
pavelhoral
left a comment
There was a problem hiding this comment.
LGTM
Changes look good, basic tests pass. I would like to run more system tests, however that can be done later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the first part of migration to the Jakarta EE specification. The main goal is to provide Tomcat 10 support.
The PR contains two significant changes:
javax.servlethas been migrated tojakarta.servlet(Jakarta Servlet 5.0)javax.security.auth.messagehas been migrated tojakarta.security.auth.messageSome external binaries were not migrated to the Jakarta EE specification, so I manually migrated them to the Jakarta Servlet 5.0 specification using the Eclipse Transformer. These binaries can be identified by the
jakarta1suffix in the version.After the change, I created a new build and verified that none of the old packages were included in the binary artifacts. The new build passed all the tests in the wrenam-test repository.