Closed
Conversation
This adds build time compatibility with JDK 21. The old build time compatibility has been dropped. Targetting lower JDK versions is still possible.
pavelhoral
commented
Jul 24, 2025
| private static final int JAVA_VERSION = Runtime.version().feature(); | ||
|
|
||
| public static List<DistributionPoint> getDistributionPoints(CRLDistributionPointsExtension extension) throws Exception { | ||
| if (JAVA_VERSION < 20) { |
Member
Author
There was a problem hiding this comment.
This approach will not suffice. The new X509 implementation has been backported to Java 17 releases as well. We will need to go the "full reflection" path.
Member
Author
There was a problem hiding this comment.
Was not able to find any mention of this being changed / backported. Strange that I am getting linking error with Java 17 - https://github.com/WrenSecurity/wrenam/actions/runs/16508743719/job/46685928744
The difference in JVM is:
- Java_Temurin-Hotspot_jdk/17.0.15-6/x64 - successful build
- Java_Temurin-Hotspot_jdk/17.0.16-8/x64 - failed build
Member
Author
There was a problem hiding this comment.
Nevermind, it is there https://bugs.openjdk.org/browse/JDK-8296072. Even backported to Oracle's Java 11.
pavelhoral
added a commit
to pavelhoral/wrenam
that referenced
this pull request
Jul 25, 2025
New JDK builds contain breaking changes in their internal API that we depend on. This fixes those incompatibilities which enables Java 21 as a side effect. Ref https://bugs.openjdk.org/browse/JDK-8296072
Member
Author
|
This has been replaced by #210. |
karelmaxa
added a commit
that referenced
this pull request
Jul 28, 2025
Fix X509 incompatibility with newer JDKs (#206)
karelmaxa
pushed a commit
to karelmaxa/wrenam
that referenced
this pull request
Jul 28, 2025
New JDK builds contain breaking changes in their internal API that we depend on. This fixes those incompatibilities which enables Java 21 as a side effect. Ref https://bugs.openjdk.org/browse/JDK-8296072
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds build time compatibility with JDK 21. The old build time compatibility has been dropped. Targetting lower JDK versions is still possible.