Skip to content

Upgrade SLF4J to 2.x#216

Merged
pavelhoral merged 1 commit intoWrenSecurity:mainfrom
kovaceviccz:upgrade-slf4j-to-2.x
Aug 6, 2025
Merged

Upgrade SLF4J to 2.x#216
pavelhoral merged 1 commit intoWrenSecurity:mainfrom
kovaceviccz:upgrade-slf4j-to-2.x

Conversation

@kovaceviccz
Copy link
Copy Markdown
Contributor

This PR addresses part of #214 by upgrading SLF4J to version 2.0.17, allowing Wren:AM deployments to use the latest versions of SLF4J logging backends, which now implement the ServiceLoader mechanism.

It introduces an AMSlf4jServiceProvider within the openam-slf4j module, replacing the old StaticLoggerBinder class.

See https://www.slf4j.org/faq.html#changesInVersion200.

@pavelhoral pavelhoral force-pushed the upgrade-slf4j-to-2.x branch from 1f6fee0 to 9ba1537 Compare August 6, 2025 06:08
Comment thread pom.xml
Copy link
Copy Markdown
Member

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kovaceviccz kovaceviccz force-pushed the upgrade-slf4j-to-2.x branch from 9ba1537 to 353c1e6 Compare August 6, 2025 09:07
Copy link
Copy Markdown
Member

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM :)

@pavelhoral pavelhoral merged commit f661917 into WrenSecurity:main Aug 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants