Add JSON debug log format#219
Merged
pavelhoral merged 3 commits intoWrenSecurity:mainfrom Aug 22, 2025
Merged
Conversation
pavelhoral
requested changes
Aug 9, 2025
kovaceviccz
force-pushed
the
add-json-debug-log-format
branch
3 times, most recently
from
511ccbe to
2bdb327
Compare
Contributor
Author
|
Thanks for going over it, @pavelhoral. I’ve made the updates you suggested and pushed a new PR version. Does this look better? |
kovaceviccz
force-pushed
the
add-json-debug-log-format
branch
4 times, most recently
from
48a39dc to
7bea3bb
Compare
kovaceviccz
force-pushed
the
add-json-debug-log-format
branch
4 times, most recently
from
ca27c0b to
c2dc75c
Compare
pavelhoral
reviewed
Aug 21, 2025
kovaceviccz
force-pushed
the
add-json-debug-log-format
branch
from
c2dc75c to
0da890d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses part of #214 by introducing a new
DebugRecordvalue object to encapsulate log entry data, and aDebugFormatterabstraction withPlainTextDebugFormatter(legacy format) andJsonDebugFormatter(structured output) implementations. The active formatter is selected via the neworg.wrensecurity.wrenam.debug.formatsystem property; for example, setting-Dorg.wrensecurity.wrenam.debug.format=jsonenables JSON-formatted debug output, while omitting it defaults to the legacy plain text format.It also replaces the legacy
SimpleDateFormatwith the thread-safeDateTimeFormatterand updates date/time formats to better align with the ISO-8601 standard.