Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenteeType added to schema #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MenteeType added to schema #60

wants to merge 1 commit into from

Conversation

sweezy793
Copy link
Collaborator

This PR closes #58

laveesh
laveesh reviewed Apr 11, 2019
View reviewed changes
Copy link

@laveesh laveesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

DivyeshPuri
DivyeshPuri suggested changes Apr 19, 2019
View reviewed changes
Copy link

@DivyeshPuri DivyeshPuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sweezy793 Resolve conflicts otherwise Looks good to me 👍

@abhishek71994
Copy link
Member

Please run a $git pull --rebase origin master, solve the conflicts, if any. And updated the PR.

abhishek71994
abhishek71994 requested changes May 15, 2019
View reviewed changes
server-api/schema/index.js
];

var dummy2 = [
let dummy2 = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename them to a more sensible name? As in dummy_mentor or dummy_mentee for example.
All of the dummy variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laveesh laveesh laveesh left review comments

@abhishek71994 abhishek71994 abhishek71994 requested changes

@DivyeshPuri DivyeshPuri DivyeshPuri requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend : Add menteeType to schema
4 participants
@sweezy793 @abhishek71994 @DivyeshPuri @laveesh