Deadlines plugin #361
Deadlines plugin #361
Conversation
WuTheFWasThat
left a comment
WuTheFWasThat
left a comment
There was a problem hiding this comment.
thanks for working on this!
BTW, related plugin, in case you haven't seen: #300
never ended up merging it though
src/plugins/deadlines/index.tsx
Outdated
| } | ||
| } | ||
|
|
||
| private async getNodeWithText(root: Path, text: String): Promise<Path | null> { |
There was a problem hiding this comment.
for efficiency, you could consider using the Marks feature
There was a problem hiding this comment.
I dont think its worth it to change it since this function is used in other places for error checking. Nodes probably don't have many children.
There was a problem hiding this comment.
it's only ever used to search for "deadlines" right?
some other benefits:
- you can have the deadlines node wherever you want, instead of at the document root
- uniqueness is guaranteed
There was a problem hiding this comment.
Yeah you're right. I'm having trouble figuring out how to check if the mark exists. I see theres a public method listMarks but I don't know how to call it.
There was a problem hiding this comment.
ahh, yeah, sorry! I think I need to add something to PluginAPI so that you can access other plugins. let me try briefly, the daily notes plugin has a similar issue
There was a problem hiding this comment.
i added a way to do this, see bb6c81e
let me know if you have questions, it's totally new so not very tested
src/plugins/deadlines/index.tsx
Outdated
| // check if row is in top level of deadlines | ||
| this.log('inDeadlines', row); | ||
| const root = await this.getDeadlinesRoot(); | ||
| const children = await this.getChildren(root); |
There was a problem hiding this comment.
might be slightly better to check getParents of row instead
src/plugins/deadlines/index.tsx
Outdated
| private async setMark(path: Path, mark: string) { | ||
| this.log('setMark', path, mark); | ||
| let info = await this.api.session.document.getInfo(path.row); | ||
| if (info.pluginData && info.pluginData.marks && info.pluginData.marks.mark !== mark) { |
|
took a quick look and this looks better now! is it ready for merge? |
|
yup thanks for the help! |
2 participants
Plugin to keep track of deadlines
Creates a "Deadlines" node at the root.
All nodes with deadlines will be automatically cloned in the Deadlines node in sorted order
Add a deadline to a node by adding a child of the form "due YYYY-MM-DD" or "due MM-DD"