Skip to content

Conversation

@hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Sep 6, 2025

This PR fixes new warnings by rust and clippy and also simplifies the CI workflow by:

  • combining build & test jobs
  • switching to Swatinem/rust-cache for our caching needs
  • directly install components instead of another step
  • test MSRV in addition to stable
  • enable workflow run on any branch

Finally, set a MSRV as listed on lib.rs (older may work, but didnt test)

@hasezoey hasezoey requested review from Wulf and longsleep September 6, 2025 13:05
Copy link
Collaborator

@longsleep longsleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - with the bump of the Rust version to 1.70 maybe the next release should reflect that by going to 0.2.0.

@hasezoey
Copy link
Collaborator Author

hasezoey commented Sep 6, 2025

with the bump of the Rust version to 1.70

I dont think we advertised any rust version before.

maybe the next release should reflect that by going to 0.2.0.

Along with some other changes, we can make it a 02.0

@hasezoey hasezoey closed this Sep 6, 2025
@hasezoey hasezoey reopened this Sep 6, 2025
@hasezoey
Copy link
Collaborator Author

hasezoey commented Sep 6, 2025

Accidentally closed, pushed the wrong button instead of "Comment".

with the bump of the Rust version to 1.70 maybe the next release should reflect that by going to 0.2.0.

I dont think we advertised a rust version before and i didnt test any lower version, but along with some other changes this will be 0.2.0.

@hasezoey hasezoey merged commit d56b152 into Wulf:main Sep 6, 2025
12 checks passed
@hasezoey hasezoey deleted the fixStyle branch September 6, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants