x86: Add Keyboard support for i8042 controller#44
Conversation
domnudragota
changed the title
|
Note: I'll move the ACK/RESEND part from the controller to the keyboard command engine only after I start work on the capsule part |
|
Note for
|
| // Peek current entry at tail and the next byte to send | ||
| let (byte_opt, done) = { | ||
| let q = self.cmd_q.borrow(); | ||
| let e = &q[self.q_tail.get()]; |
There was a problem hiding this comment.
Do we need to use indexing here?
There was a problem hiding this comment.
At first I though it might be useful, now I realized it can panic on any small slip, should be fixed in 96f6762
There was a problem hiding this comment.
Can you explain what this does and if it could actually OOB?
There was a problem hiding this comment.
That block just peeks the current command in the ring buffer. q.get(tail) is bounds-checked; it returns None instead of panicking if the index were bad. Because we modulo the indexes and check q_count > 0 first, the index shouldn’t be OOB.
If a bug slipped through, the None path bails out (no panic).
There was a problem hiding this comment.
Update after d25859b,
the command queue now uses a small Fifo<CmdEntry, N>. We (hopefully) don't index with integers anymore; peek()/peek_mut() return an Option and push()/pop() handle wrap-around internally, so OOB cannot occur. Inside a CmdEntry, we only read bytes[idx] after verifying idx < len (is_done()), keeping that access safe.
| } else { | ||
| // Logging | ||
| if b >= 0x20 && b != 0x7F { | ||
| debug!("ps2-kbd: ASCII '{}'", b as char); |
There was a problem hiding this comment.
| debug!("ps2-kbd: ASCII '{}'", b as char); |
There was a problem hiding this comment.
can we at least document these messages somewhere for people in the future ?, they are removed in 96f6762
| if b >= 0x20 && b != 0x7F { | ||
| debug!("ps2-kbd: ASCII '{}'", b as char); | ||
| } else { | ||
| debug!("ps2-kbd: ASCII 0x{:02x}", b); |
There was a problem hiding this comment.
| debug!("ps2-kbd: ASCII 0x{:02x}", b); |
There was a problem hiding this comment.
can we at least document these messages somewhere for people in the future ?, they are removed in 96f6762
There was a problem hiding this comment.
What do you mean by document?
There was a problem hiding this comment.
Add a small comment to let people know they can use some commands to debug the controller + keyboard :D
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Looks good, send it to upstream.
88296c7 to
b91c7ad
Compare
1392160 to
0d862a9
Compare
…vide API for keyevent/keyboardClient
…, optional AsciiClient for future capsule
… keyboard works, removed debug messages
7194e7a to
842c77b
Compare
2 participants
Pull Request Overview
This pull request adds driver support for a keyboard device. It implements the client from the PS/2 controller
Testing Strategy
This pull request was tested by @domnudragota, keyboard can decode button presses + modifiers (no numpad yet)
TODO or Help Wanted
This pull request will need a capsule when porting the Process Console (?) to VGA. This is just the driver itself.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.