x86_q35: add TextScreen HIL adapter for VGA text mode (PART 1)#48
Open
domnudragota wants to merge 1 commit into
Open
x86_q35: add TextScreen HIL adapter for VGA text mode (PART 1)#48domnudragota wants to merge 1 commit into
domnudragota wants to merge 1 commit into
Conversation
domnudragota
marked this pull request as ready for review
September 18, 2025 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds a TextScreen HIL implementation for VGA text mode on x86_q35, without changing any board wiring yet.
New typed VGA text-mode writer (chips/x86_q35/src/vga.rs): 80×25 buffer, cursor, scroll, UTF-8→CP437/ASCII fallbacks.
Chip-side adapter (chips/x86_q35/src/vga_textscreen.rs) implementing kernel::hil::text_screen::TextScreen.
print() renders immediately and completes split-phase via a deferred call (write_complete).
Cursor/display commands complete synchronously and call command_complete(Ok(())).
Kept the legacy vga_uart_driver.rs compiling (adjusted to generic Vga). No behavior changes to existing UART console paths.
Testing Strategy
This pull request was tested by...
TODO or Help Wanted
This pull request still needs:
Follow-up PR: wire ProcessConsole to the new TextScreen adapter (replace the UART façade on the board).
Follow-up PR: PS/2 controller + keyboard device using kernel::hil::keyboard, delivering Linux keycodes to the console capsule.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.