chore: refactor commands and connection type into traits#46
Merged
Conversation
added 9 commits
June 30, 2025 22:10
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
added 2 commits
June 30, 2025 23:30
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
Signed-off-by: George Cosma <george.cosma@wyliodrin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better visibility and extensibility, refactored
install,list, andinfocommands into their own traits and implemented them on 3 new structures:ProbeRSConnection,SerialConnection, and a generealized type which can be used in lieu ofBox<dyn Connection>calledTockloaderConnection. The former could be later replaced with dynamic dispatch crate for auto-implementation if manual upkeep gtst bothersome