Fixed clippy warning uninlined_format_args#51
Conversation
eva-cosma
left a comment
eva-cosma
left a comment
There was a problem hiding this comment.
Well done! I have one change request. Other than that, make sure you follow the conventional commits format, and I suggest you merge your commits into a single one. You would do this using git rebase, but be careful when using it!
|
Also I took the liberty to change your PR message to link the issue (you pasted the entire link to the project's view off the issue instead of just refereincing the number (aka Re-request my review when it is ready |
|
The commit message is unclear. You merged all commit messages into one, instead of creating a new one that explains very briefly what this pr is about (fix: ....) |
- Used named arguments within the format strings instead of passing them as separate arguments. - Declared constants for ANSI escape codes which i used throughout the entire code to make it more readable. - Added RESET after each color or each line.
|
@george-cosma should be good now i hope |
|
Also, I didn't ask but at this point it's a bit late since i merged, did you test out the code on hardware to see if it's all okay @AliwiWalid? :)) |
|
Um well apologies but i kind of forgot, ill do that now regardless but hopefully shouldnt be any issues. Live and learn! |
2 participants
Pull Request Overview
This pull request fixes clippy's
uninlined_format_argsby removing the#[allow(clippy:uninlined_format_args)]directives from the tockloader-cli/src/display.rs file.TODO or Help Wanted
N/A
Checks
Using Rust tooling
cargo fmtcargo clippycargo testcargo buildGitHub Issue
This pull request closes #47