Skip to content

Find altool using xcrun instead of hard-coding the tool path #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgrebenets wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Find altool using xcrun instead of hard-coding the tool path #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions lib/fastlane/plugin/altool/actions/altool_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@
module Fastlane
module Actions
class AltoolAction < Action
ALTOOL= File.expand_path('/Applications/Xcode.app/Contents/Applications/Application\ Loader.app/Contents/Frameworks/ITunesSoftwareService.framework/Support/altool')
puts ALTOOL
def self.run(params)
altool = `xcrun -f altool`.chomp
UI.message("altool binary doesn't exist at path: #{altool}") unless File.exist?(altool)

UI.message(" ----altool binary exists on your machine----- ")

altool_app_type = params[:altool_app_type]
Expand All @@ -17,9 +18,9 @@ def self.run(params)
ENV["ALTOOL_PASSWORD"] = params[:altool_password]
altool_password = "@env:ALTOOL_PASSWORD"

UI.message("========Validating and Uploading your ipa file to iTunes Connect=========")
UI.message("========Validating and Uploading your IPA file to iTunes Connect=========")
command = [
ALTOOL,
altool,
'--upload-app',
'-t',
altool_app_type,
Expand All @@ -33,7 +34,7 @@ def self.run(params)
altool_output_format
]
Actions.sh(command.join(' '))
UI.message("========It maight take so long time to fully upload your IPA files=========")
UI.message("========It might take long time to fully upload your IPA file=========")
end

def self.description
Expand All @@ -50,7 +51,7 @@ def self.return_value

def self.details
# Optional:
"This plugin can be used for uploading ipa files to iTunes Connect using altool rahter than using ITMSTransporter.. Currently Fastlane deliver upload an ipa file using iTMSTransporter tool. There is another slick command line too called altool that can be used to upload ipa files as well"
"This plugin can be used for uploading ipa files to iTunes Connect using altool rather than using ITMSTransporter.. Currently Fastlane deliver upload an ipa file using iTMSTransporter tool. There is another slick command line too called altool that can be used to upload ipa files as well"
end

def self.available_options
Expand Down Expand Up @@ -79,16 +80,14 @@ def self.available_options
description: "Your Apple ID for iTunes Connects. This usually FASTLANE_USER environmental variable",
is_string: true,
default_value: ENV["FASTLANE_USER"],
optional: false,
),
optional: false),

FastlaneCore::ConfigItem.new(key: :altool_password,
env_name: "ALTOOL_PASSWORD",
description: "Your Apple ID Password for iTunes Connects. This usually FASTLANE_PASSWORD environmental variable",
is_string: true,
default_value: ENV["FASTLANE_PASSWORD"],
optional: true,
),
optional: true),

FastlaneCore::ConfigItem.new(key: :altool_output_format,
env_name: "ALTOOL_OUTPUT_FORMAT",
Expand Down