-
-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add netscape bookmark import/export #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds import and export functionality for browser bookmarks in Netscape format, allowing users to transfer their collections to/from other browsers. The implementation includes parsing bookmarks from HTML files, converting them to the app's collection structure, and exporting collections back to standard bookmark format.
Key changes:
- Added
node-bookmarks-parserdependency for parsing Netscape-format bookmark files - Implemented bidirectional conversion between browser bookmarks and app collections
- Added UI section in Storage settings for bookmark import/export operations
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added node-bookmarks-parser dependency for bookmark parsing |
| package-lock.json | Lockfile updates for new dependency and its transitive dependencies (cheerio, parse5, etc.) |
| locales/*.yml | Added translations for bookmark import/export UI in 8 languages |
| features/netscapeBookmarks/utils/importBookmarks.ts | Handles file selection, parsing, and importing bookmarks into collections |
| features/netscapeBookmarks/utils/exportBookmarks.ts | Generates Netscape-format HTML from collections and triggers download |
| features/netscapeBookmarks/utils/convertBookmarks.ts | Converts parsed bookmarks to app's collection data structure |
| features/netscapeBookmarks/layouts/BookmarksSection.tsx | UI component with import/export buttons and result messaging |
| entrypoints/options/layouts/StorageSection.tsx | Integrates BookmarksSection into storage settings page with reorganized layout |
| entrypoints/options/hooks/useOptionsStyles.ts | Added messageBar style for consistent MessageBar display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@SheepDomination I've made the changes. Can you check if this is what you wanted? |
Description
Resolves: #203