-
-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add ability to hide collections #211 #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a feature to hide and unhide collections, allowing users to declutter their collection list while retaining access to hidden items through a toggle filter. The implementation adds a new optional hidden boolean property to the collection model, integrates hide/unhide actions into the collection menu, and provides filtering UI in the searchbar.
- Added
hiddenproperty to CollectionItem model - Implemented hide/unhide toggle in collection three-dot menu with visual feedback
- Added "Show hidden" filter checkbox in the filter menu (off by default to hide hidden collections)
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| models/CollectionModels.ts | Added optional hidden boolean property to CollectionItem type |
| entrypoints/sidepanel/utils/filterCollections.ts | Updated filtering logic to exclude hidden collections unless showHidden is true; added showHidden to filter type |
| entrypoints/sidepanel/layouts/collections/CollectionListView.tsx | Added showHidden state management and wired it into filter callbacks |
| entrypoints/sidepanel/layouts/collections/SearchBar.tsx | Updated props to pass showHidden state to FilterCollectionsButton |
| entrypoints/sidepanel/layouts/collections/FilterCollectionsButton.tsx | Added "Show hidden" checkbox to filter menu with icon; updated callback signature to handle showHidden state |
| entrypoints/sidepanel/components/collections/CollectionMoreButton.tsx | Added hide/unhide menu item with conditional icon and label based on current hidden state |
| entrypoints/sidepanel/components/collections/CollectionHeader.tsx | Added eye-off icon indicator for hidden collections in the title area |
| locales/en.yml | Added English translations for hide/unhide actions and show hidden filter |
| locales/es.yml | Added Spanish translations |
| locales/it.yml | Added Italian translations |
| locales/pl.yml | Added Polish translations |
| locales/pt_BR.yml | Added Brazilian Portuguese translations |
| locales/ru.yml | Added Russian translations |
| locales/uk.yml | Added Ukrainian translations |
| locales/zh_CN.yml | Added Simplified Chinese translations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
entrypoints/sidepanel/layouts/collections/FilterCollectionsButton.tsx
Outdated
Show resolved
Hide resolved
entrypoints/sidepanel/layouts/collections/FilterCollectionsButton.tsx
Outdated
Show resolved
Hide resolved
entrypoints/sidepanel/components/collections/CollectionMoreButton.tsx
Outdated
Show resolved
Hide resolved
|
@lpoirothattermann hey! I've made the changes. Can you check if this is what you wanted? |
|
@XFox111 hey! lgtm, thanks for the development, just tested it and it works great! |
* feat: add ability to hide collections #211 (#213) * feat: add ability to hide collections #211 * fix: hide/unhide collection label is swapped * fix: missing useCallback dependency * fix: add selected tabs to existing collection adds all tabs in current window #215 (#216) * fix: add selected tabs to existing collection adds all tabs in current window #215 * fix: force selected tabs only for adding tabs to groups * feat: compact collection view (#214) * feat: compact collection view #201 * loc: compact view localization * fix(loc): missing "color" translation in edit dialog * feat: add ability to edit saved tabs (#218) * feat: adds option to edit saved tabs #217 * loc: translations for #217 * build(deps): Bump the react group with 2 updates (#221) Bumps the react group with 2 updates: [react](https://github.com/facebook/react/tree/HEAD/packages/react) and [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom). Updates `react` from 19.2.1 to 19.2.3 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.3/packages/react) Updates `react-dom` from 19.2.1 to 19.2.3 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.3/packages/react-dom) --- updated-dependencies: - dependency-name: react dependency-version: 19.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: react - dependency-name: react-dom dependency-version: 19.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: react ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): Bump the deps group with 4 updates (#220) Bumps the deps group with 4 updates: [@fluentui/react-components](https://github.com/microsoft/fluentui), [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js), [eslint](https://github.com/eslint/eslint) and [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint). Updates `@fluentui/react-components` from 9.72.8 to 9.72.9 - [Release notes](https://github.com/microsoft/fluentui/releases) - [Commits](https://github.com/microsoft/fluentui/compare/@fluentui/react-components_v9.72.8...@fluentui/react-components_v9.72.9) Updates `@eslint/js` from 9.39.1 to 9.39.2 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](https://github.com/eslint/eslint/commits/v9.39.2/packages/js) Updates `eslint` from 9.39.1 to 9.39.2 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.1...v9.39.2) Updates `typescript-eslint` from 8.49.0 to 8.51.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.51.0/packages/typescript-eslint) --- updated-dependencies: - dependency-name: "@fluentui/react-components" dependency-version: 9.72.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: deps - dependency-name: "@eslint/js" dependency-version: 9.39.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: deps - dependency-name: eslint dependency-version: 9.39.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: deps - dependency-name: typescript-eslint dependency-version: 8.51.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: deps ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Bump version from 3.2.3 to 3.3.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description
Added ability to hide/unhide collections.
Resolves: #211