Skip to content

Conversation

@XFox111
Copy link
Owner

@XFox111 XFox111 commented Dec 27, 2025

Description

  • When hovering over a saved tab, three-dot menu button will be shown instead of delete button. Clicking on it will provide options to edit or delete the tab.
  • Both tab's title and URL can be edited.
  • URL is required (at least 1 non-whitespace character)
  • Changing URL will reset tab's icon and thumbnail, as they are tied to that specific original URL

Resolves: #217

@XFox111 XFox111 added this to the Patch Tuesday. January 2025 milestone Dec 27, 2025
@XFox111 XFox111 self-assigned this Dec 27, 2025
Copilot AI review requested due to automatic review settings December 27, 2025 13:10
@XFox111 XFox111 added enhancement New feature or request user-interface locale javascript Pull requests that update javascript code labels Dec 27, 2025
@XFox111 XFox111 linked an issue Dec 27, 2025 that may be closed by this pull request
1 task
@XFox111
Copy link
Owner Author

XFox111 commented Dec 27, 2025

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements the ability to edit saved tabs by replacing the delete button with a three-dot menu that offers both edit and delete options. When editing, users can modify both the tab's title and URL, with URL validation ensuring at least one non-whitespace character is required.

Key Changes:

  • Added edit functionality for saved tabs with a dedicated edit dialog component
  • Replaced direct delete button with a three-dot menu providing edit and delete actions
  • Implemented URL validation with error messaging in multiple languages

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
locales/*.yml Added translations for "edit_tab" dialog title and "url_error" validation message across 7 languages
entrypoints/sidepanel/components/TabEditDialog.tsx New dialog component for editing tab title and URL with form validation
entrypoints/sidepanel/components/TabMoreButton.tsx New three-dot menu button component offering edit and delete options
entrypoints/sidepanel/components/TabView.tsx Updated to use TabMoreButton, added handleEdit function and collectionId prop
entrypoints/sidepanel/components/GroupView.tsx Threads collectionId prop to child TabView components
entrypoints/sidepanel/components/CollectionView.tsx Passes collection timestamp as collectionId to child components
entrypoints/sidepanel/layouts/collections/CollectionListView.tsx Passes -1 as collectionId for drag overlay instances

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@XFox111
Copy link
Owner Author

XFox111 commented Dec 27, 2025

Also, I've just noticed that you answered "yes" to "Are you willing to submit a PR for this issue?" question on all your issues. So, I assume, you wanted to do them yourself. Sorry, if that's the case :)

@lpoirothattermann
Copy link

@lpoirothattermann you know the gist :) https://github.com/XFox111/TabsAsideExtension/actions/runs/20539454949?pr=218

As always, works like a charm. Thank you @XFox111!

Also, I've just noticed that you answered "yes" to "Are you willing to submit a PR for this issue?" question on all your issues. So, I assume, you wanted to do them yourself. Sorry, if that's the case :)

I'm glad that you did the implementations, mine wouldn't be as good. I looked at the repository code, looks very clean and reliable. Thanks for your work :)

@XFox111 XFox111 merged commit 12cd5f7 into next Dec 30, 2025
10 checks passed
@XFox111 XFox111 deleted the 217-edit-tabs branch December 30, 2025 17:39
@XFox111 XFox111 mentioned this pull request Jan 3, 2026
5 tasks
XFox111 added a commit that referenced this pull request Jan 3, 2026
* feat: add ability to hide collections #211 (#213)

* feat: add ability to hide collections #211

* fix: hide/unhide collection label is swapped

* fix: missing useCallback dependency

* fix: add selected tabs to existing collection adds all tabs in current window #215 (#216)

* fix: add selected tabs to existing collection adds all tabs in current window #215

* fix: force selected tabs only for adding tabs to groups

* feat: compact collection view (#214)

* feat: compact collection view #201

* loc: compact view localization

* fix(loc): missing "color" translation in edit dialog

* feat: add ability to edit saved tabs (#218)

* feat: adds option to edit saved tabs #217

* loc: translations for #217

* build(deps): Bump the react group with 2 updates (#221)

Bumps the react group with 2 updates: [react](https://github.com/facebook/react/tree/HEAD/packages/react) and [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom).


Updates `react` from 19.2.1 to 19.2.3
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/v19.2.3/packages/react)

Updates `react-dom` from 19.2.1 to 19.2.3
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/v19.2.3/packages/react-dom)

---
updated-dependencies:
- dependency-name: react
  dependency-version: 19.2.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: react
- dependency-name: react-dom
  dependency-version: 19.2.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: react
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): Bump the deps group with 4 updates (#220)

Bumps the deps group with 4 updates: [@fluentui/react-components](https://github.com/microsoft/fluentui), [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js), [eslint](https://github.com/eslint/eslint) and [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint).


Updates `@fluentui/react-components` from 9.72.8 to 9.72.9
- [Release notes](https://github.com/microsoft/fluentui/releases)
- [Commits](https://github.com/microsoft/fluentui/compare/@fluentui/react-components_v9.72.8...@fluentui/react-components_v9.72.9)

Updates `@eslint/js` from 9.39.1 to 9.39.2
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](https://github.com/eslint/eslint/commits/v9.39.2/packages/js)

Updates `eslint` from 9.39.1 to 9.39.2
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.1...v9.39.2)

Updates `typescript-eslint` from 8.49.0 to 8.51.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.51.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: "@fluentui/react-components"
  dependency-version: 9.72.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: deps
- dependency-name: "@eslint/js"
  dependency-version: 9.39.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: deps
- dependency-name: eslint
  dependency-version: 9.39.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: deps
- dependency-name: typescript-eslint
  dependency-version: 8.51.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: deps
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Bump version from 3.2.3 to 3.3.0

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request javascript Pull requests that update javascript code locale user-interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Ability to rename tabs in collection

3 participants