fix: opening tab context menu causes tab to open on Firefox #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XFox111
added
bug
2 tasks
Owner
Author
|
Hey @lpoirothattermann, I checked it on my machine, LGTM. Is it good on yours? https://github.com/XFox111/TabsAsideExtension/actions/runs/20895188373?pr=225 |
There was a problem hiding this comment.
Pull request overview
This PR fixes a Firefox-specific bug where clicking the three-dot menu button on a saved tab would inadvertently open that tab. The fix prevents event propagation and default behavior when the menu button is clicked.
Changes:
- Added
preventDefault()to the menu button's click handler to prevent the parent Link's default navigation behavior - Added
disableButtonEnhancementprop to MenuTrigger for proper event handling consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @XFox111, good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where on Firefox, clicking on three-dot menu button of a saved tab causes the tab to be opened.
Resolves: #224