fix: postgres json/jsonb null comparison causes startup failure#17
Merged
Conversation
…tgres migrations PostgreSQL has no implicit cast between json and jsonb, so comparing a json column with 'null'::jsonb raises "operator does not exist: json = jsonb". Cast to text instead, which works for both json and jsonb column types. Fixes startup failure on fresh databases with the TimescaleDB backend. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonandjsonb, so the migration queries in_upgrade_schemaand_needs_migration_syncthat compared ajsoncolumn against'null'::jsonbraisedoperator does not exist: json = jsonbvalue::text = 'null', which works correctly regardless of whether the column isjsonorjsonb0.3.2Root cause
BaseSQLStoredefines thevaluecolumn using SQLAlchemy's genericJSONtype, which PostgreSQL maps tojson(notjsonb). The migration code then tried to compare it with'null'::jsonb, which PostgreSQL rejects.Test plan
pytest)🤖 Generated with Claude Code