feat(management): implement dm_authorize and dm_connect procedures - #1833
Draft
kewde wants to merge 6 commits into
Draft
feat(management): implement dm_authorize and dm_connect procedures#1833kewde wants to merge 6 commits into
kewde wants to merge 6 commits into
Conversation
- Simple procedures (dm_restart, nm_individual_address_check) now take conn: P2PConnection directly; callers own the connection lifecycle - Complex procedures (nm_individual_address_write) keep ConnectionManager + Broadcaster signatures to manage their own connection lifecycle - Legacy wrappers open/close connections and delegate to clean functions - Add legacy tests for dm_restart and all nm_individual_address_* wrappers - Document T_Connect-PDU = A_Connect at wire level (KNX 03.03.07 §3.5.1)
Adds DMP_Authorize_RCo, DMP_Authorize2_RCo (KNX 03.05.02 §3.5) and DM_Connect (§3.2.1) to the device/ procedure package, using the new P2PConnection protocol API.
farmio
reviewed
May 19, 2026
- Remove unnecessary ellipsis constants after docstrings in Protocol method bodies (W2301) - Replace reimport aliasing pattern in procedures/__init__.py with explicit assignments to avoid W0404
kewde
force-pushed
the
kewde/refactor-procedures-2
branch
4 times, most recently
from
August 1, 2026 22:21
574e855 to
96a0b31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
procedures that need to open/close their own connections keep ConnectionManager / Broadcaster signatures. Legacy wrappers are preserved to maintain backwards compatibility.
better). Full test coverage including the equal-level edge case.
framework.
Fixes # (issue)
Type of change
Checklist