-
Notifications
You must be signed in to change notification settings - Fork 1.1k
XLS-0066 Lending Protocol #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,810
−10
Merged
Changes from 124 commits
Commits
Show all changes
137 commits
Select commit
Hold shift + click to select a range
ba3a750
adds lending protocol spec
Tapanito d3e6115
improves the description of the management fee
Tapanito b297e6e
renames field names from plural to singular
Tapanito aac7f3e
This commit introduces the following changes:
Tapanito f18e8f1
removes CoverAvailable check from LoanBrokerDelete transaction
Tapanito 44e1b57
Apply suggestions from code review
Tapanito 1a437ee
cleans up latex code
Tapanito 9f47ea2
updates LoanDelete transaction to delete the LoanBroker DirectoryNode…
Tapanito 60a311e
in case insufficient first loss capital add loan broker fees to cover…
Tapanito 9090bd3
fixes loan object ownership
Tapanito 8851620
adds pseudo-account to the LoanBroker
Tapanito 0f6644c
adds counterparty to LoanSet transaction
Tapanito 14a634f
updates failure conditions of LoanSet transaction
Tapanito b77401b
Update XLS-0066d-lending-protocol/README.md
Tapanito aa50126
addresses PR comments
Tapanito 9acddc1
fixes signature field name
Tapanito 294f582
changes internal type of cover rate variables
Tapanito 8740e2f
renames singular vault attributes to plural
Tapanito b175402
Apply suggestions from code review
Tapanito 36ec7cb
changes Amount type to AMOUNT
Tapanito 6c9a815
adds owner reserve chages to LoanSet
Tapanito ea0f369
changes InterestRate type to uint32
Tapanito 0b13609
adds missing overpayment fields to LoanSet transaction
Tapanito b631e67
adds pseudo-account locked/frozen checks to LoanBrokerCoverWithdraw
Tapanito ff058bf
Update XLS-0066d-lending-protocol/README.md
Tapanito 1398766
Improves how Loan ID is calculated by introducing a new LoanSequence …
Tapanito 01d8981
removes sequence from the Loan object
Tapanito 7e923c2
Apply suggestions from code review
Tapanito 5609061
addresses PR comments
Tapanito b16dad1
Apply suggestions from code review
Tapanito 65cc318
Apply suggestions from code review
Tapanito 4ff2165
Update XLS-0066d-lending-protocol/README.md
Tapanito 33908af
Update XLS-0066d-lending-protocol/README.md
Tapanito b8f8b6f
adds checks for frozen LoanBroker pseudo-account
Tapanito fe723a2
clarifies LoanPay totalDue and totalPaid
Tapanito 389dd2e
corrects LoanSet debtMaximum and coverAvailable checks
Tapanito fd20def
improves LoanManage readability with ReturnToVault variable
Tapanito 321319e
adds checks to LoanPay to ensure both Vault pseudo-account and LoanbR…
Tapanito d45aeb5
adds calculations for secondsSinceLastPayment
Tapanito 81e2ff8
adds destination field to the LoanBrokerCoverWithdraw transaction
Tapanito 3eee2bd
Update XLS-0066d-lending-protocol/README.md
Tapanito ed5a62d
adds LoanBrokerCoverClawback transaction
Tapanito f992b00
Apply suggestions from code review
Tapanito e4930c6
adds deepfreeze flag checks where appropriate
Tapanito 71b9e36
Apply suggestions from code review
Tapanito 47ece0f
improves freeze documentation
Tapanito 43eeab3
removes LoanDraw transaction, as a result removes Loan.AssetsAvailabl…
Tapanito ca55bb1
adds LedgerEntryType and TransactionType values
Tapanito 1ca3389
fixes basis point inconcisitencies in LoanSet transaction
Tapanito cdc45a6
lints the markdown using pretier
Tapanito c1411aa
updates preamble to follow the new format
Tapanito 069a910
clarifies which fields are modifiable with the LoanBrokerSet transaction
Tapanito 02a27d9
fixes flag names
Tapanito 2c2524e
improves variable name consistency
Tapanito 6b04e50
Merge branch 'master' into xls-66-lending-protocol
Tapanito 4ba07c6
adds DebtTotal > 0 condition to LoanBrokerDelete
Tapanito 4b02ae4
adds Loan.TotalValueOutstanding
Tapanito a43426e
adds Loan.PrincipalRequested
Tapanito 7022130
adds authentication requirements to the loanset transaction
Tapanito 2ef8f5a
fixes debt maximum calculation
Tapanito 0a05584
improves the handling of fees when loanbroker account is frozen
Tapanito 2977f04
Merge branch 'master' into xls-66-lending-protocol
Tapanito 63730e5
improves the pseudo-code accuracy and removes bugs in late payment co…
Tapanito ead6cec
adds loan overpayment flag to LoanPay transaction
Tapanito 1607e70
adds description of rounding error handling
Tapanito 5dda351
adds balance checks to loan pay
Tapanito 1933a4a
adds loan scale field
Tapanito b855be2
completely rewrites they loanPay transaction
Tapanito 789ee88
adds extra guards to loanset transaction
Tapanito b976847
adds missing fullpayment flag in pseudo-code
Tapanito d644b04
adds missing fee
Tapanito 77d789c
adds missing fee
Tapanito 853563d
adds exclusivit check for overpayment and earrly payment flags
Tapanito 732b33e
renames PreviousPaymentDate to PreviousPaymentDueDate
Tapanito a383bf3
adds updated LoanPay logic
Tapanito 805e1f4
improves CoverRate docs
Tapanito 3c2cdc5
restores excess handling
Tapanito 2f0db96
adds equation glossary
Tapanito cc0559a
adds valueChange to 3.2.4.2
Tapanito 238b204
fixes LoanSequence
Tapanito 9059014
removes accountID from loanID generation
Tapanito f97480d
adds tfLoanlatePayment flag
Tapanito 607b67f
Merge branch 'master' into xls-66-lending-protocol
Tapanito ef0f8f8
fixes typos
Tapanito 1a73a6c
runs prettier
Tapanito 4e2de5d
additional typos
Tapanito e5d13b7
additional typos
Tapanito 692dab9
adds additional failure condition to the LoanSet tx
Tapanito 3eb18b7
adds min gracePeriod duration
Tapanito c2d8849
improves overpayment pseudo-code
Tapanito bbf8952
improves LoanBrokerSet documentation
Tapanito f223966
improves LoanBrokerDelete documentation
Tapanito 11296ec
improves LoanBrokerCoverDeposit documentation
Tapanito 3cb170d
improves LoanBrokerCoverWithdraw documentation
Tapanito dffa4e2
improves LoanBrokerCoverClawback documentation
Tapanito 3d209f1
improves LoanSet documentation
Tapanito eb3cb4b
improves LoanDelete documentation
Tapanito f674331
improves LoanManage documentation
Tapanito c37438f
improves LoanPay documentation
Tapanito 841c18d
renames lendipng protocol directory and moves pseudo-code for appendix
Tapanito 7474e70
adds docs note
Tapanito 935eb22
improves the strucutre of LoanPay transaction
Tapanito 9af3874
Merge branch 'master' into xls-66-lending-protocol
Tapanito 845cb42
Merge branch 'master' into xls-66-lending-protocol
Tapanito b66ba8d
Merge branch 'master' into xls-66-lending-protocol
Tapanito ccb8dff
Merge branch 'master' into xls-66-lending-protocol
mvadari 601b242
Merge branch 'master' into xls-66-lending-protocol
mvadari d7d5dfb
minor improvements to the xls
Tapanito 537d0b6
Merge branch 'master' into xls-66-lending-protocol
Tapanito ffefd65
fixes flag json type
Tapanito 6d6d2b5
fixes default withdraw/deposit amount
Tapanito 6e850ae
cleans up json types
Tapanito 3ee5011
Merge branch 'master' into xls-66-lending-protocol
Tapanito 4be7e22
addresses review comments
Tapanito 9e86622
minor gramatical improvements
Tapanito d36d45d
formatting
Tapanito 541acc6
Merge branch 'master' into xls-66-lending-protocol
Tapanito 7cd84ae
fix: markdown formatting for heavy check mark
AdamJSc c7eb35a
changes pseudo-account description
Tapanito a3f3999
adds destination tag to loakBrokerCoverWithdraw
Tapanito 7234c44
Merge pull request #4 from AdamJSc/patch-3
Tapanito 22ba1d9
formatting
Tapanito 6853e2c
Merge branch 'master' into xls-66-lending-protocol
Tapanito e01ad40
updates links in sav to lending protocol
Tapanito 9c9ca35
updates the outer strucutre of the specification
Tapanito 90bfdef
updates iner specification structure
Tapanito 319c1c4
adds json examples
Tapanito fdbf53b
filss objecgt deleion'
Tapanito a40eb11
fills freezing section
Tapanito 2a6771b
adds error codes
Tapanito 5ff33c5
adds rationale
Tapanito 79ef0f1
Merge branch 'master' into xls-66-lending-protocol
Tapanito c6a3746
addresses review comments
Tapanito d0c1ea6
one more style fix
Tapanito 308d052
adds svg architeture diagram
Tapanito 8ca02d6
changes examples from code mode to md
Tapanito 65b54ad
Merge branch 'master' into xls-66-lending-protocol
Tapanito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.