Skip to content

XLS-0094d-dynamic-MPT#302

Merged
mvadari merged 15 commits intoXRPLF:masterfrom
yinyiqian1:dynamic_mpt
Sep 5, 2025
Merged

XLS-0094d-dynamic-MPT#302
mvadari merged 15 commits intoXRPLF:masterfrom
yinyiqian1:dynamic_mpt

Conversation

@yinyiqian1
Copy link
Contributor

@yinyiqian1 yinyiqian1 commented Aug 5, 2025

discussion link: #289

Copy link
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, left some nits

@mvadari
Copy link
Collaborator

mvadari commented Sep 4, 2025

@yinyiqian1 is this ready to merge? I can merge it if you address my comment.

@yinyiqian1
Copy link
Contributor Author

@yinyiqian1 is this ready to merge? I can merge it if you address my comment.

@mvadari I just updated the spec. I added the link in discussion-from line, please let me know if you prefer changing it back to a raw address.
Other than that, the rest is ready to merge.

@mvadari
Copy link
Collaborator

mvadari commented Sep 5, 2025

@yinyiqian1 is this ready to merge? I can merge it if you address my comment.

@mvadari I just updated the spec. I added the link in discussion-from line, please let me know if you prefer changing it back to a raw address.
Other than that, the rest is ready to merge.

Raw address is preferable for now - that section is displayed with code formatting, so the link won't work.

@yinyiqian1
Copy link
Contributor Author

@yinyiqian1 is this ready to merge? I can merge it if you address my comment.

@mvadari I just updated the spec. I added the link in discussion-from line, please let me know if you prefer changing it back to a raw address.
Other than that, the rest is ready to merge.

Raw address is preferable for now - that section is displayed with code formatting, so the link won't work.

Sure. I just changed it back.

@mvadari
Copy link
Collaborator

mvadari commented Sep 5, 2025

@yinyiqian1 please fix the linting check and it'll be good to merge (apologies for the addition in the checks, the repo is in some amount of flux at the moment)

@mvadari mvadari merged commit a76ff99 into XRPLF:master Sep 5, 2025
2 checks passed
mvadari pushed a commit to mvadari/XRPL-Standards that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants