Conversation
shawnxie999
left a comment
There was a problem hiding this comment.
👍 looks good, left some nits
|
@yinyiqian1 is this ready to merge? I can merge it if you address my comment. |
@mvadari I just updated the spec. I added the link in |
Raw address is preferable for now - that section is displayed with code formatting, so the link won't work. |
Sure. I just changed it back. |
|
@yinyiqian1 please fix the linting check and it'll be good to merge (apologies for the addition in the checks, the repo is in some amount of flux at the moment) |
discussion link: #289