-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add XLS-60d: 0060 XLS-60d: DefaultAutoBridge #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
08f59cd
Add XLS-60d: 0060 XLS-60d: DefaultAutoBridge
mvadari a1b411a
Update XLS-0060-default-autobridge/README.md
mvadari 8dca101
Merge branch 'master' into xls-60d
mvadari d336c35
Update XLS-0060-default-autobridge/README.md
mvadari ab40666
Merge branch 'master' into xls-60d
Tapanito 80a77f8
Merge branch 'master' into xls-60d
Tapanito 687c275
Merge branch 'master' into xls-60d
mvadari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| <pre> | ||
| xls: 60 | ||
| title: DefaultAutoBridge | ||
| author: tequ (@tequdev) | ||
| created: 2024-02-05 | ||
| status: Stagnant | ||
| category: Amendment | ||
| </pre> | ||
|
|
||
| ## Abstract | ||
|
|
||
| Currently, if the Path field is not specified in an IOU-IOU Payment transaction, only direct pairs of two currencies are used internally. This proposal would change this default behavior to use IOU-XRP-IOU as well as OfferCreate transaction's. | ||
|
|
||
| ## Changes | ||
|
|
||
| If the Path field is unspecified in the IOU_A->IOU_B Payment transaction, the path through IOU_A/XRP and IOU_B/XRP is used in addition to the IOU_A/IOU_B path. | ||
|
|
||
| If existing transaction types or future transaction types to be implemented are similarly cross-currency transactions, it will be possible to use bridge paths in addition to direct paths by default. | ||
|
|
||
| ### Technical | ||
|
|
||
| Add an additional path with XRP as the intermediate between two currencies to in flow() method in Flow.cpp when `defaultPaths`=`true`. | ||
|
|
||
| Use XRP-mediated paths to the paths under the following conditions: | ||
|
|
||
| - Path is not specified | ||
| - SendMax is set. | ||
| - The issuer and currency of Amount and SendMax are different. | ||
|
|
||
| ### Payment transaction | ||
|
|
||
| If the Path field is not specified and the SendMax field is set, the transaction will use the XRP-mediated path. | ||
|
|
||
| No impact if the NoRippleDirect flag is set. | ||
|
|
||
| ### OfferCreate transaction | ||
|
|
||
| No impact as Path is always set. | ||
|
|
||
| ### CheckCash transaction | ||
|
|
||
| (using flow()) | ||
|
|
||
| No impact as it only processes when the fields corresponding to Amount and SendMax are the same. | ||
|
|
||
| _If future amendments allow cross-currency checks, composite paths will be available._ | ||
|
|
||
| ### XChainBridge transaction | ||
|
|
||
| (using flow()) | ||
|
|
||
| No impact as SendMax is processed as null. | ||
|
|
||
| ### PathFind command | ||
|
|
||
| (using flow()) | ||
| No impact as DefaultPaths is false. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.