Open
Conversation
intelliot
force-pushed
the
fix-broken-links-with-symlinks
branch
from
c69dce5 to
8089f02
Compare
intelliot
force-pushed
the
fix-broken-links-with-symlinks
branch
from
8089f02 to
709b1b5
Compare
- Skip symlinked README files when checking for duplicate XLS numbers - Add validation to ensure symlinks point to correct targets - Preserves symlinks for backward compatibility with external URLs - Fixes CI validation errors while maintaining proper document structure
Collaborator
|
I don't like this change, feels like it'll just clutter up the repo. Plus it's pretty easy to fix the documentation that points to it. |
Contributor
Author
|
It's not only documentation that points to it - there are broken links in various places on the web and in chats |
Contributor
Author
|
I've run into lots of them. Here's one example: XRPLF/rippled#5060 - try clicking the link to the XLS spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation elsewhere links to:
Permission Delegation - https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0075d-permission-delegation
Batch - https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0056d-batch
Those are currently returning 404s, let's try fixing that with these symlinks.